Skip to content

fix: add missing ecs:TagResource permission for ECS tasks #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

fix: add missing ecs:TagResource permission for ECS tasks #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/deploy/stepFunctions/compileIamRole.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function getGluePermissions() {

function getEcsPermissions() {
return [{
action: 'ecs:RunTask,ecs:StopTask,ecs:DescribeTasks,iam:PassRole',
action: 'ecs:RunTask,ecs:StopTask,ecs:DescribeTasks,ecs:TagResource,iam:PassRole',
resource: '*',
}, {
action: 'events:PutTargets,events:PutRule,events:DescribeRule',
Expand Down
4 changes: 2 additions & 2 deletions lib/deploy/stepFunctions/compileIamRole.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1651,7 +1651,7 @@ describe('#compileIamRole', () => {
.provider.compiledCloudFormationTemplate.Resources.StateMachine1Role
.Properties.Policies[0].PolicyDocument.Statement;

const ecsPermissions = statements.filter(s => _.isEqual(s.Action, ['ecs:RunTask', 'ecs:StopTask', 'ecs:DescribeTasks', 'iam:PassRole']));
const ecsPermissions = statements.filter(s => _.isEqual(s.Action, ['ecs:RunTask', 'ecs:StopTask', 'ecs:DescribeTasks', 'ecs:TagResource', 'iam:PassRole']));
expect(ecsPermissions).to.have.lengthOf(1);
expect(ecsPermissions[0].Resource).to.equal('*');

Expand Down Expand Up @@ -2694,7 +2694,7 @@ describe('#compileIamRole', () => {
const expectation = (policy, lambdaArns, sns, sqsArn) => {
const statements = policy.PolicyDocument.Statement;

const ecsPermissions = statements.filter(s => _.isEqual(s.Action, ['ecs:RunTask', 'ecs:StopTask', 'ecs:DescribeTasks', 'iam:PassRole']));
const ecsPermissions = statements.filter(s => _.isEqual(s.Action, ['ecs:RunTask', 'ecs:StopTask', 'ecs:DescribeTasks', 'ecs:TagResource', 'iam:PassRole']));
expect(ecsPermissions).to.have.lengthOf(1);
expect(ecsPermissions[0].Resource).to.equal('*');

Expand Down
Loading