--file argument analogous to nix build & friends
#320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a --file option, which forces the non-flake build logic to always run, regardless of whether or not the current nix is flake-enabled. This allows using deploy-rs with repositories which do not use flakes at all but use an external source-managing tool such as niv or npins (the previous behaviour could only really support flake-based repositories with a flake-compat fallback defined in default.nix).
This does two things: - lift the restriction on remote builds with legacy nix; the logic remains the same and we use `nix --experimental-features nix-command' to call Nix - change the logic on build drivers: if we do a remote build, use the nix-command setup even if we're not using a flake-enabled nix (this still assumes the remote host has a nix version > 2.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--fileoption, which allows usingdeployin repositories which are not nix flakes.deploy-rsalready has support for falling back to a non-flake version of its logic in case thenixavailable in$PATHdoesn't have the flake experimental feature flag enabled. However, that's an "if and only if"-situation: if the nix is flakes-enabled, there's no way to use the non-flake version. This works well for setups which use nix flakes, but provides a flake-compatdefault.nixfallback, but prevents use ofdeploy-rsin setups which do not use flakes at all but rely on another source-managing tool such asnivornpins.--filetakes as argument a path, and--targetsand other options continue to work as expected; remote builds also work assuming a new enough nix on the target host. I've also added tests for local & remote builds (and fixed the name of thenon-flake-buildtest; looks like i forgot that when I introduced it in #272)