Skip to content

update flake and rust dependencies #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Chaostheorie
Copy link

This is a naive update with minor adjustments for new APIs. Most changes are clap related because their macro naming has changed.

@Chaostheorie
Copy link
Author

The only skipped dependency is rnix, it had a few breaking API changes that likely require a bigger refactor. I can try to tackle this in the new few days.

@Chaostheorie
Copy link
Author

Chaostheorie commented Mar 27, 2025

This also now contains a minor fix for #307 and #287, if required, this can be split into its own PR

@Chaostheorie
Copy link
Author

Tested the PR locally, works fine. No regression appears to be present.

This a naive update with minor adjustements for new APIs. Most changes
are clap related because their macro naming has changed.
Extend ast handling for nodename with dots, see serokell#307
@Chaostheorie
Copy link
Author

After an hour on a builder, nixos vm test failed, seems like activation CLI needs some more work:

vm-test-run-options-overriding> client # thread 'tokio-runtime-worker' panicked at /build/source/src/deploy.rs:493:37:
vm-test-run-options-overriding> client # called `Result::unwrap()` on an `Err` value: ()

Copy link

@weriomat weriomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I have debugged the issue with the tests.
Since you bumped the nixpkgs version, this commit removes the switch-to-configuration script by default.
We should enable this option in the common config because the test VMs need to have the new rust script in path (since they cannot fetch it while being run)

Copy link

@weriomat weriomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overlay outputs seems to be deprecated as well in favor of overlays.default

weriomat added 2 commits May 13, 2025 16:49
…loys

[This](NixOS/nixpkgs@4cfbbb3)
commit has disabled the option by default, but we need the
`switch-to-configuration` binary in order to successfully deploy to the
server
Fix tests + overlays output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants