Skip to content

updating to check if the number is actually a credit card using luhn #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updating to check if the number is actually a credit card using luhn #35

wants to merge 2 commits into from

Conversation

dicko2
Copy link

@dicko2 dicko2 commented Feb 23, 2024

This was masking session IDs in my application

@sandermvanvliet
Copy link
Contributor

@dicko2 always a risk when using regexes...

Could you please add tests that demonstrate the new behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@raresChelariu raresChelariu raresChelariu approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dicko2 @sandermvanvliet @raresChelariu