This repository was archived by the owner on Jun 13, 2023. It is now read-only.
WIP: Support nested lists with maps #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present implementation coerces sequences it can't determine the type of to a string set and calls
toStringon it's members. This simple form of improvised serialization can work in most cases, but tends to be an impediment in the case of nested object graphs.This patch is conceptually similar to #99, but also unpacks the values to their AWScala equivalents
aws.dynamodb.model.AttributeValue => AttributeValueon fetch. This is meant as a step towards #110, but a real fix for that would require removing theJMapsignature of themproperty, for example. Fixing that would seem to unblock true native document support, as requested in #103 and #66.Would appreciate feedback on the approach here as parts feel a bit clumsy.