Skip to content

Fix dashboard display for disabled checks and improve wording#49

Merged
arktronic-sep merged 6 commits intomainfrom
misc-fixes
Mar 10, 2026
Merged

Fix dashboard display for disabled checks and improve wording#49
arktronic-sep merged 6 commits intomainfrom
misc-fixes

Conversation

@arktronic-sep
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes two complementary changes: (1) fixes the dashboard's incident timeline and response time trends to properly handle disabled checks instead of completely filtering them out, and (2) renames the user-facing status label from "Warn"/"Warning" to "Degraded" across the UI, documentation, and notification services.

Changes:

  • Updated CheckQueryService to include disabled checks with historical data in the incident timeline (using an increment-boundary cutoff approach) and to skip disabled checks with no data in response time trends
  • Renamed all user-facing instances of "Warn"/"Warning" status label to "Degraded" across Razor pages, documentation, and the alert change detection service
  • Updated integration tests to verify the new disabled check timeline behavior and adjusted unit test assertions for the "Degraded" wording

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
SAMA.Web/Services/Queries/CheckQueryService.cs Core logic: include disabled checks' historical data in incident timeline using cutoff boundaries; skip empty disabled checks in response time trends
SAMA.Web/Services/AlertChangeDetectionService.cs Changed "Warn" to "Degraded" in BuildCreationInfo output
SAMA.Web/Pages/Dashboard/Index.cshtml Renamed "warning"/"Warn" to "degraded"/"Degraded" in status display text
SAMA.Web/Pages/Dashboard/_IncidentTimelineChart.cshtml Renamed legend and tooltip labels from "Warning"/"Warn" to "Degraded"
SAMA.Web/Pages/Workspaces/Index.cshtml Renamed health popover and badge from "Warning" to "Degraded"
SAMA.Web/Pages/Checks/Details.cshtml Renamed status text, badge, and popover from "Warning"/"Warn" to "Degraded"
SAMA.Web/Pages/Checks/_UptimeDisplay.cshtml Renamed "Warn" to "Degraded" in uptime breakdown label
SAMA.Web/Pages/Checks/_TlsConfigFields.cshtml Renamed status description from "Warn" to "Degraded"
SAMA.Web/Pages/Checks/_HttpConfigFields.cshtml Renamed threshold description from "Warn" to "Degraded"
SAMA.Web/Pages/Alerts/*.cshtml Renamed trigger badges and descriptions from "Warn"/"Warning" to "Degraded" across Create, Edit, Details, Delete, Index
SAMA.Web/Pages/EventSubscriptions/Index.cshtml Renamed status transitions and descriptions from "Warn" to "Degraded"
SAMA.Tests.Unit/Web/Services/AlertChangeDetectionServiceTests.cs Updated test assertions for "Degraded" output
SAMA.Tests.Integration/Web/Services/Queries/CheckQueryServiceTests.cs Replaced old test with two new tests covering disabled check historical data and cutoff behavior
README.md Renamed status labels from "Warn" to "Degraded"
docs/DESIGN_SYSTEM.md Renamed status color description from "warn" to "degraded"
docs/ARCHITECTURE.md Renamed status references from "Warn" to "Degraded"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

@arktronic-sep arktronic-sep merged commit 7bf0d37 into main Mar 10, 2026
8 checks passed
@arktronic-sep arktronic-sep deleted the misc-fixes branch March 10, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants