Skip to content

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Oct 3, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7591](https://sendbird.atlassian.net/browse/CLNP-7591)

Description Of Changes

  • Expo 54 지원을 위해서 expo-av 대신 expo-audio, expo-video 도 사용가능하도록 변경하였습니다
  • AudioPlay 시에는 별도의 권한이 필요하지않아보여 requestPermission 리턴값은 true 로 고정하였습니다,
  • interface ExpoPushPermissionResponse 타입에러 발생하여 수정하였습니다.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee changed the title feat: add support for expo-video and expo-audio for Expo SDK 54 [CLNP-7591] feat: add support for expo-video and expo-audio for Expo SDK 54 Oct 3, 2025
@OnestarLee OnestarLee requested a review from Copilot October 3, 2025 07:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Expo SDK 54 by enabling the use of expo-audio and expo-video packages alongside the existing expo-av package. This provides a migration path for users who want to adopt the newer, more specialized audio and video packages while maintaining backward compatibility.

  • Added expo-audio and expo-video as optional dependencies
  • Created adapter pattern to support both legacy expo-av and new separated modules
  • Fixed TypeScript interface conflicts in ExpoPushPermissionResponse

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/uikit-react-native/src/utils/expoPermissionGranted.ts Fixed type conflict in ExpoPushPermissionResponse interface
packages/uikit-react-native/src/utils/expoBackwardUtils.ts Added utility functions to detect and differentiate between expo-av and new separated modules
packages/uikit-react-native/src/platform/createRecorderService.expo.tsx Refactored to support both expo-av and expo-audio through adapter pattern
packages/uikit-react-native/src/platform/createPlayerService.expo.tsx Refactored to support both expo-av and expo-audio through adapter pattern
packages/uikit-react-native/src/platform/createMediaService.expo.tsx Refactored to support both expo-av and expo-video through adapter pattern
packages/uikit-react-native/package.json Added expo-audio and expo-video as optional dependencies
docs-validation/1_introduction/NativeModules.tsx Updated example to use new separated modules

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 352 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.85%. Comparing base (220fe84) to head (041693e).

Files with missing lines Patch % Lines
...native/src/platform/createRecorderService.expo.tsx 0.00% 156 Missing ⚠️
...t-native/src/platform/createPlayerService.expo.tsx 0.00% 146 Missing ⚠️
...ct-native/src/platform/createMediaService.expo.tsx 0.00% 38 Missing ⚠️
.../uikit-react-native/src/utils/expoBackwardUtils.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   11.09%   10.85%   -0.24%     
==========================================
  Files         360      360              
  Lines        8818     9011     +193     
  Branches     2478     2543      +65     
==========================================
  Hits          978      978              
- Misses       7839     7957     +118     
- Partials        1       76      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee requested a review from bang9 October 3, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants