-
Notifications
You must be signed in to change notification settings - Fork 45
[CLNP-7591] feat: add support for expo-video and expo-audio for Expo SDK 54 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Expo SDK 54 by enabling the use of expo-audio and expo-video packages alongside the existing expo-av package. This provides a migration path for users who want to adopt the newer, more specialized audio and video packages while maintaining backward compatibility.
- Added expo-audio and expo-video as optional dependencies
- Created adapter pattern to support both legacy expo-av and new separated modules
- Fixed TypeScript interface conflicts in ExpoPushPermissionResponse
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/uikit-react-native/src/utils/expoPermissionGranted.ts | Fixed type conflict in ExpoPushPermissionResponse interface |
packages/uikit-react-native/src/utils/expoBackwardUtils.ts | Added utility functions to detect and differentiate between expo-av and new separated modules |
packages/uikit-react-native/src/platform/createRecorderService.expo.tsx | Refactored to support both expo-av and expo-audio through adapter pattern |
packages/uikit-react-native/src/platform/createPlayerService.expo.tsx | Refactored to support both expo-av and expo-audio through adapter pattern |
packages/uikit-react-native/src/platform/createMediaService.expo.tsx | Refactored to support both expo-av and expo-video through adapter pattern |
packages/uikit-react-native/package.json | Added expo-audio and expo-video as optional dependencies |
docs-validation/1_introduction/NativeModules.tsx | Updated example to use new separated modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 11.09% 10.85% -0.24%
==========================================
Files 360 360
Lines 8818 9011 +193
Branches 2478 2543 +65
==========================================
Hits 978 978
- Misses 7839 7957 +118
- Partials 1 76 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-7591](https://sendbird.atlassian.net/browse/CLNP-7591)
Description Of Changes
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_