This repository was archived by the owner on Nov 19, 2024. It is now read-only.
feat: support EIP-4844 transactions #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchapalaver
force-pushed
the
joseph/tru-203-implement-eip-4844-in-transactionstransactionrs
branch
from
8a0ef92 to
a64110a
Compare
pedrohba1
reviewed
Aug 28, 2024
| }) | ||
| } | ||
| TxType::Eip4844 => unimplemented!(), | ||
| TxType::Eip4844 => Transaction::Eip4844(TxEip4844 { |
There was a problem hiding this comment.
When reconstructing the transaction, it might run into a similar problem you had in Execution Block to Header conversion, check if you can get the transaction hash matching from the data just to be sure. There should be a build in method to create the hash from the transaction, but if not, the process is just to rlp encode it's data, hash it and then compare to what it is supposed to be
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRU-203