Merge pull request #9 from seisigmasrl/feature/rnc-type

Improving the Package Toolset
seisigmasrl · Feb 7, 2023 · 49b2d50 · 49b2d50
2 parents b9c8d75 + 4955ea5
commit 49b2d50
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/src/helpers/Types.php b/src/helpers/Types.php
@@ -14,17 +14,8 @@ public function toString(): string
     {
         return match ($this) {
             self::RNC => 'RNC',
-            self::CEDULA => 'Cédula',
-            self::PASSPORT => 'Pasaporte',
-        };
-    }
-
-    public function fromString(string $string): self
-    {
-        return match ($string) {
-            'RNC' => self::RNC,
-            'Cédula' => self::CEDULA,
-            'Pasaporte' => self::PASSPORT,
+            self::CEDULA => 'CEDULA',
+            self::PASSPORT => 'PASSPORT',
         };
     }
 }
diff --git a/tests/DgiiRncValidatorTest.php b/tests/DgiiRncValidatorTest.php
@@ -11,7 +11,7 @@
 
 test('check rncType return the type name', function () {
     expect(DgiiRncValidator::rncType('123456789'))->toBe('RNC')
-        ->and(DgiiRncValidator::rncType('12345678901'))->toBe('Cédula');
+        ->and(DgiiRncValidator::rncType('12345678901'))->toBe('CEDULA');
 });
 
 it('can return the details of an RNC if true', function () {