feat: add trustPeriod and backfillBlocks to configure-state-sync#28
Merged
feat: add trustPeriod and backfillBlocks to configure-state-sync#28
Conversation
b054b76 to
f032771
Compare
Extend the configure-state-sync task to accept trustPeriod and backfillBlocks parameters from the controller. This allows the controller to derive sane defaults based on the node bootstrap strategy rather than requiring users to set these values. - Add TrustPeriod and BackfillBlocks to ConfigureStateSyncTask - Refactor Configure() to accept StateSyncParams struct - Write trust-period and backfill-blocks to config.toml when set - Add TestStateSyncConfigurer_NetworkWithBackfill test
f032771 to
b534842
Compare
|
Suggested version: Changes in (empty)
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure-state-synctask to accepttrustPeriodandbackfillBlocksparameters from the controllerStateSyncParamsstruct to group the optional parameters passed toConfigure()Changes
sidecar/client/tasks.go: AddTrustPeriodandBackfillBlocksfields toConfigureStateSyncTask, conditionally include in task request paramssidecar/tasks/statesync.go: Add fields toStateSyncConfig, refactorConfigure()to acceptStateSyncParams, writetrust-periodandbackfill-blocksto config.toml when setsidecar/tasks/statesync_test.go: Update existing tests for new signature, addTestStateSyncConfigurer_NetworkWithBackfillTest plan