[codex] bump go-ethereum to v1.15.7-sei-17 by codchen · Pull Request #3657 · sei-protocol/sei-chain

codchen · 2026-06-29T12:26:23Z

Summary

Bump the Sei go-ethereum fork replacement from v1.15.7-sei-16 to v1.15.7-sei-17.
Refresh the corresponding go.sum checksums with go mod tidy.

Impact

This updates the EVM dependency fork used by the existing github.com/ethereum/go-ethereum replace directive without changing the upstream module requirement shape.

Validation

go mod verify
go test ./x/evm/... ./evmrpc/...

github-actions · 2026-06-29T12:28:00Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Jun 29, 2026, 3:44 PM

cursor · 2026-06-29T12:29:38Z

PR Summary

Medium Risk
EVM execution depends on this fork, so any behavioral change in sei-17 affects consensus and RPC paths even though this PR only retargets the replace and checksums.

Overview
Bumps the Sei go-ethereum fork used via the existing replace in go.mod from v1.15.7-sei-16 to v1.15.7-sei-17. The upstream require line for github.com/ethereum/go-ethereum is unchanged; only which fork revision is resolved at build time changes.

go.sum is updated with the new module checksums for github.com/sei-protocol/go-ethereum v1.15.7-sei-17. There are no changes to chain or EVM application code in this diff—only dependency pinning.

^{Reviewed by Cursor Bugbot for commit 8ebd52e. Bugbot is set up for automated code reviews on this repo. Configure here.}

seidroid

A minimal, mechanically clean bump of the sei-protocol/go-ethereum fork replace directive from v1.15.7-sei-16 to v1.15.7-sei-17, touching only go.mod and go.sum. The diff itself is correct; the substantive risk lives in the fork's source changes, which are not visible in this PR.

Findings: 0 blocking | 3 non-blocking | 0 posted inline

Blockers

None at the file/PR level.

Non-blocking

The go.sum update is internally consistent: the fork's h1 source hash changed (sei-16 -> sei-17) while the /go.mod hash stayed identical, indicating the fork's go.mod was unchanged and only source code differs — as expected for this kind of bump.
The actual behavioral changes in the fork (sei-16 -> sei-17) are not part of this diff and cannot be reviewed here. Since the PR is labeled app-hash-breaking, confirm the EVM/consensus impact has been validated (the PR cites go mod verify and go test ./x/evm/... ./evmrpc/...) and that node operators are aware this requires a coordinated upgrade.
Second-opinion passes were effectively empty: Codex reported no material findings but could not run Go verification (sandbox had Go 1.24.13, not the required 1.25.6, with network blocked); the Cursor review file was empty/produced no output.

seidroid

A minimal dependency bump of the Sei go-ethereum fork (v1.15.7-sei-16 → sei-17) with a consistent go.sum refresh; the go.mod/go.sum changes are internally coherent. The only concern is an undocumented CI change (verify: false) bundled in alongside the dependency bump.

Findings: 0 blocking | 4 non-blocking | 1 posted inline

Blockers

None at the file/PR level.

Non-blocking

The verify: false change in .github/workflows/golangci.yml is unrelated to the dependency bump and is not mentioned in the PR description. It disables golangci-lint-action's config-schema verification, slightly weakening CI signal. Consider documenting why it's needed (e.g. a v2.8.0 schema-validation incompatibility) or splitting it into its own PR.
The fork's actual code changes (sei-16 → sei-17) cannot be reviewed from this repository and aren't summarized in the PR; given the app-hash-breaking label, a brief note in the description on what changed in the fork would help reviewers assess consensus risk.
Cursor's second-opinion review produced no output (empty file); Codex reported no material findings.
1 suggestion(s)/nit(s) flagged inline on specific lines.

seidroid · 2026-06-29T12:38:53Z

        with:
          version: v2.8.0
          args: --timeout 10m0s
+          verify: false


[suggestion] This verify: false addition is unrelated to the go-ethereum bump described in the PR. It disables golangci-lint-action's verification of the .golangci.yml config against its schema, which reduces CI's ability to catch malformed lint config. If it's a workaround for a v2.8.0 schema-validation issue, please note the reason; otherwise consider keeping it in a separate, dedicated change.

@codchen why verify false?

guh I guess I need to housetrain codex better

codecov · 2026-06-29T12:45:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.18%. Comparing base (c713a03) to head (8ebd52e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
- Coverage   59.14%   58.18%   -0.97%     
==========================================
  Files        2262     2178      -84     
  Lines      187031   177408    -9623     
==========================================
- Hits       110625   103226    -7399     
+ Misses      66456    65023    -1433     
+ Partials     9950     9159     -791

Flag	Coverage Δ
sei-db	`70.41% <ø> (-0.22%)`	⬇️
sei-db-state-db	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.
see 85 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

masih

Extra context needed to explain why golangci verify is disabled here

seidroid

Routine dependency bump of the Sei go-ethereum fork from v1.15.7-sei-16 to v1.15.7-sei-17 with a refreshed go.sum, plus an unrelated CI change disabling golangci-lint config verification. The go.mod/go.sum changes are consistent and well-formed; the only points of note are the CI tweak and the fact that the fork's actual contents can't be reviewed from this diff.

Findings: 0 blocking | 5 non-blocking | 1 posted inline

Blockers

None at the file/PR level.

Non-blocking

The substantive change is the go-ethereum fork bump, but the actual source delta between sei-16 and sei-17 is not visible in this diff. Since the PR is labeled app-hash-breaking, reviewers should confirm the fork changelog/commits and that the listed validation (go mod verify, go test ./x/evm/... ./evmrpc/...) plus app-hash regression tests actually passed before merge.
go.mod/go.sum changes are consistent: the replace directive, both go.sum hash lines, and the unchanged go.mod hash all line up correctly for the version bump.
Codex's second-opinion pass reported no material findings (it could not run Go validation due to a Go 1.24 sandbox and blocked network).
Cursor's second-opinion review file (cursor-review.md) was empty — that pass produced no output.
1 suggestion(s)/nit(s) flagged inline on specific lines.

seidroid · 2026-06-29T14:40:59Z

        with:
          version: v2.8.0
          args: --timeout 10m0s
+          verify: false


[suggestion] Adding verify: false disables golangci-lint-action's validation of .golangci.yml against its JSON schema. This is unrelated to a go-ethereum bump and silences config-schema errors going forward, so a malformed lint config could slip through unnoticed. Consider whether this is intentional/permanent, and if it's only a workaround for a transient v2.8.0 schema mismatch, add a comment noting why and when it can be removed.

seidroid

Mechanical bump of the sei-protocol/go-ethereum fork replacement from v1.15.7-sei-16 to v1.15.7-sei-17 with refreshed go.sum checksums; the diff is internally consistent and correct, but the actual behavioral changes live in the fork and cannot be reviewed from this PR.

Findings: 0 blocking | 3 non-blocking | 0 posted inline

Blockers

None at the file/PR level.

Non-blocking

The substantive changes are in the go-ethereum fork between sei-16 and sei-17 and are not visible in this diff. Since the PR is labeled app-hash-breaking and backport release/v6.6, confirm the fork delta is consensus-safe, intentionally app-hash-breaking (coordinated with the upgrade/release that activates it), and that the Validation steps (go mod verify, go test ./x/evm/... ./evmrpc/...) actually passed before merge.
The go.sum change correctly updates only the package h1: hash while leaving the /go.mod hash unchanged, consistent with a source-only fork change. No issue, just confirming integrity.
Cursor's second-opinion review file (cursor-review.md) was empty, so no Cursor findings were available to incorporate. Codex reported no material findings but noted it could not validate (sandbox had Go 1.24.13, cannot fetch the required Go 1.25.6 toolchain), so neither external pass independently verified the build/tests.

seidroid · 2026-06-29T17:09:49Z

Successfully created backport PR for release/v6.6:

Backport release/v6.6: [codex] bump go-ethereum to v1.15.7-sei-17 #3662

…3662) Backport of #3657 to `release/v6.6`. Co-authored-by: Tony Chen <codchen03@gmail.com>

* main: feat(seid): ConfigManager selection seam (PLT-775 PR1) (#3671) fix(evmrpc): limit listener max open connections, configurable via max_open_connections (PLT-704) (#3637) LittDB: Keymap threading improvements (#3645) integrate hashlogger (#3647) fix(metrics): Prometheus metrics output (#3640) [codex] Harden multiversion iterator validation (#3656) feat(consensus): mock_chain_validation replay build + memIAVL state-sync restore fixes (#3663) chore: replace OLD red SeiLogo banner in README with new 2026 Sei lockup (#3670) Require absolute path for evmone lib (#3668) fix(evmrpc): apply getLogs maxLog cap during merge instead of after (PLT-687) (#3666) feat(evmrpc): pre-decode request size admission control (PLT-295) (#3648) Make autobahn block production check wait for progress (#3667) fix(sei-tendermint): prevent readRoutine goroutine leak on /websocket when writeChan is full (PLT-707) (#3664) Per-block littidx flush + single shard (gated on #3645) (#3660) fix(evmrpc): bound debug_traceStateAccess memory and add trace admission control (PLT-360) (#3653) [codex] bump go-ethereum to v1.15.7-sei-17 (#3657) Upodate checkout GHA step across all workflows (#3659) Add GoReleaser release pipeline for static seid binaries (#3425) Parallelize littidx eth_getLogs across blocks (#3652)

codchen marked this pull request as ready for review June 29, 2026 12:28

codchen requested review from masih and philipsu522 June 29, 2026 12:29

codchen added the app-hash-breaking label Jun 29, 2026

sei-will approved these changes Jun 29, 2026

View reviewed changes

seidroid Bot approved these changes Jun 29, 2026

View reviewed changes

masih approved these changes Jun 29, 2026

View reviewed changes

seidroid Bot approved these changes Jun 29, 2026

View reviewed changes

masih added the backport release/v6.6 Backport to release v6.6 label Jun 29, 2026

masih requested changes Jun 29, 2026

View reviewed changes

seidroid Bot approved these changes Jun 29, 2026

View reviewed changes

bump go-ethereum to v1.15.7-sei-17

8ebd52e

codchen force-pushed the codex/bump-go-ethereum-v1.15.7-sei-17 branch from 08bfb65 to 8ebd52e Compare June 29, 2026 15:42

seidroid Bot approved these changes Jun 29, 2026

View reviewed changes

masih approved these changes Jun 29, 2026

View reviewed changes

masih added this pull request to the merge queue Jun 29, 2026

Merged via the queue into main with commit 9944128 Jun 29, 2026
67 checks passed

masih deleted the codex/bump-go-ethereum-v1.15.7-sei-17 branch June 29, 2026 17:08

seidroid Bot mentioned this pull request Jun 29, 2026

Backport release/v6.6: [codex] bump go-ethereum to v1.15.7-sei-17 #3662

Merged

masih pushed a commit that referenced this pull request Jun 30, 2026

Backport release/v6.6: [codex] bump go-ethereum to v1.15.7-sei-17 (#…

ae6a51e

…3662) Backport of #3657 to `release/v6.6`. Co-authored-by: Tony Chen <codchen03@gmail.com>

Uh oh!

Conversation

codchen commented Jun 29, 2026

Summary

Impact

Validation

Uh oh!

github-actions Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

seidroid Bot left a comment

Choose a reason for hiding this comment

Blockers

Non-blocking

Uh oh!

seidroid Bot left a comment

Choose a reason for hiding this comment

Blockers

Non-blocking

Uh oh!

seidroid Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

masih Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

codchen Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

masih left a comment

Choose a reason for hiding this comment

Uh oh!

seidroid Bot left a comment

Choose a reason for hiding this comment

Blockers

Non-blocking

Uh oh!

seidroid Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

seidroid Bot left a comment

Choose a reason for hiding this comment

Blockers

Non-blocking

Uh oh!

Uh oh!

seidroid Bot commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 29, 2026 •

edited

Loading

cursor Bot commented Jun 29, 2026 •

edited

Loading

codecov Bot commented Jun 29, 2026 •

edited

Loading