-
Notifications
You must be signed in to change notification settings - Fork 885
feat(grpc): add keepalive, LimitListener, and MaxRecvMsgSize to gRPC server :9090 (PLT-705) #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
aea7c9d
added sei-cosmos new config params
amir-deris 1174ddf
Merge branch 'main' into amir/plt-705-sei-cosmos-grpc-config
amir-deris c5e988a
Added negative duration validation and test
amir-deris 3dec7df
Merge branch 'main' into amir/plt-705-sei-cosmos-grpc-config
amir-deris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Negative
max-open-connectionsinapp.toml(e.g.-1) silently sets the cap to unlimited, defeating the DoS bound this PR installs.v.GetUint("grpc.max-open-connections")returns 0 for negative inputs (cast.ToUintE swallowserrNegativeNotAllowed), and then theif cfg.MaxOpenConnections > 0guard inStartGRPCServerskips thenetutil.LimitListenerwrap entirely. Apply the same defensive patternclampNonNegativeDurationuses for durations: read as a signed int and fall back toDefaultGRPCMaxOpenConnectionson negative values. (The same gap also exists for the newgrpc.max-recv-msg-sizefield.)Extended reasoning...
Bug
server/config/config.go:480-483readsgrpc.max-open-connectionsviav.GetUint. When an operator writes a negative value such asmax-open-connections = -1inapp.toml(typo, stale config, or-1 means unlimitedassumption from systems like Postgres / Go'shttp.Server), the value flows through the cast/viper chain to a silent 0:cast@v1.10.0/number.go:287toUnsignedNumberEreturns(0, errNegativeNotAllowed)when given a negative integer.viper.GetUintcallscast.ToUintwhich discards that error and returns 0.v.IsSet("grpc.max-open-connections")is true for an explicit-1, so theIsSetguard does not fall through toDefaultGRPCMaxOpenConnections.grpcMaxOpenConnectionsis assigned the silently-coerceduint(0).Then at
server/grpc/server.go:68-74:0skips the wrap entirely — the explicitly documentedunlimitedbranch (see the field doc atconfig.go:225-226and the constant doc atconfig.go:33-35). Net effect: a single-character typo inapp.tomlsilently converts the connection cap to UNLIMITED — the exact DoS surface this PR is meant to bound.Why this contradicts the PR's own pattern
The PR explicitly defends against negative-misconfiguration for durations via
clampNonNegativeDuration(config.go:410-416), with the comment:That reasoning applies more strongly to
max-open-connections, since the PR description identifies the connection cap as "the actual DoS bound" — not the keepalive durations. The asymmetry is the bug.Step-by-step proof
Operator intent: "set a finite limit" (or "unlimited" via the
-1convention from other systems). Actual behavior: unlimited, silently, with no warning logged.Fix
Mirror the duration-clamp pattern with a signed read. Roughly:
The same gap also exists for
grpc.max-recv-msg-size(config.go:478): a negative override there would be clamped at theserver.go:24-27layer (if maxRecvMsgSize <= 0 { maxRecvMsgSize = DefaultGRPCMaxRecvMsgSize }) rather than at config-parse time, so the symptom is muted but the asymmetry with the duration clamp remains — worth fixing in the same pass.