chore(evmrpc): return null for unknown/empty block hash#3067
Open
mojtaba-esk wants to merge 3 commits intomainfrom
Open
chore(evmrpc): return null for unknown/empty block hash#3067mojtaba-esk wants to merge 3 commits intomainfrom
mojtaba-esk wants to merge 3 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
+ Coverage 58.41% 58.58% +0.17%
==========================================
Files 2081 2080 -1
Lines 171790 171581 -209
==========================================
+ Hits 100352 100525 +173
+ Misses 62504 62140 -364
+ Partials 8934 8916 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## Describe your changes and provide context Closes PLT-163 Ref [PLT-163](https://linear.app/seilabs/issue/PLT-163/fix-eth-getblockreceipts-not-found-behavior-parity-null-expected) ## Testing performed to validate your change ``` === RUN TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-empty.iox rpc_io_test.go:79: [DEBUG] SEI_EVM_IO_SEED_BLOCK="" rpc_io_test.go:114: [DEBUG] pair 1: placeholders=[] bindings=map[] rpc_io_test.go:129: [DEBUG] pair 1: request {"jsonrpc":"2.0","id":1,"method":"eth_getBlockReceipts","params":["0x0000000000000000000000000000000000000000000000000000000000000000"]} rpc_io_test.go:144: [DEBUG] pair 1: bindings after apply: map[] === RUN TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-not-found.iox rpc_io_test.go:79: [DEBUG] SEI_EVM_IO_SEED_BLOCK="" rpc_io_test.go:114: [DEBUG] pair 1: placeholders=[] bindings=map[] rpc_io_test.go:129: [DEBUG] pair 1: request {"jsonrpc":"2.0","id":1,"method":"eth_getBlockReceipts","params":["0x00000000000000000000000000000000000000000000000000000000deadbeef"]} rpc_io_test.go:144: [DEBUG] pair 1: bindings after apply: map[] --- PASS: TestEVMRPCSpec (0.00s) --- PASS: TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-empty.iox (0.00s) --- PASS: TestEVMRPCSpec/eth_getBlockReceipts/get-block-receipts-not-found.iox (0.00s) ``` Co-authored-by: Mojtaba <mojtaba@celestia.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Fixes PLT-162
Ref: PLT-162
Testing performed to validate your change