Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update destination functions - including variable scoping [DOC-1065].md #7512

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sade-wusi
Copy link
Contributor

Proposed changes

Added section on variable scoping

Merge timing

24th March

Related issues

PR 7511

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@@ -79,6 +79,12 @@ To change which event type the handler listens to, you can rename it to the name
> info ""
> Functions' runtime includes a `fetch()` polyfill using a `node-fetch` package. Check out the [node-fetch documentation](https://www.npmjs.com/package/node-fetch){:target="_blank"} for usage examples.

### Variable scoping

When declaring settings variables, make sure to declare them in the function handler rather than globally in your Function. This prevents you leaking the settings values across other function instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When declaring settings variables, make sure to declare them in the function handler rather than globally in your Function. This prevents you leaking the settings values across other function instances.
When declaring settings variables, declare them in the function handler rather than globally in your function. This prevents you from leaking the settings values across other function instances.


When declaring settings variables, make sure to declare them in the function handler rather than globally in your Function. This prevents you leaking the settings values across other function instances.

The handler for Destination functions is event-specific, for example, `onTrack()`, `onIdentify()`, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The handler for Destination functions is event-specific, for example, `onTrack()`, `onIdentify()`, etc.
The handler for destination functions is event-specific. For example, you might have an `onTrack()`or `onIdentify()` function handler.

Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We like to avoid Latin phrases as much as possible (e.g., etc.,)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants