Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubspot (Classic) destination fixes #7496

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Hubspot (Classic) destination fixes #7496

merged 2 commits into from
Mar 20, 2025

Conversation

stayseesong
Copy link
Contributor

Proposed changes

Received a fix request on our docs channel: https://twilio.slack.com/archives/CD3LFFTFZ/p1741971557362979)

Also put in a fix for the maintenance mode banner as "(Classic)" was being repeated twice

Merge timing

Related issues (optional)

@stayseesong stayseesong added the fixed-content fix to content that has outdated or wrong information label Mar 14, 2025
@stayseesong stayseesong requested a review from a team as a code owner March 14, 2025 21:51
@@ -223,7 +223,7 @@ When using any of Segment's server-side sources, a connector infers `traits.life

### Loading Forms SDK

Segment gives you the option to load the [HubSpot Forms SDK](https://developers.hubspot.com/docs/methods/forms/advanced_form_options){:target="_blank"} alongside their tracking library. Enable the **Load Forms SDK** setting when you your HubSpot integration.
Segment gives you the option to load the [HubSpot Forms SDK](https://developers.hubspot.com/docs/methods/forms/advanced_form_options){:target="_blank"} alongside their tracking library. Enable the **Load Forms SDK** setting for your HubSpot integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "their tracking library" referring to a HubSpot tracking library, or A.js/something on the Segment side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HubSpot

@stayseesong stayseesong merged commit e16b923 into develop Mar 20, 2025
4 checks passed
@stayseesong stayseesong deleted the fix-031425 branch March 20, 2025 16:59
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants