-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove note callouts from the docs #7433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forstisabella
commented
Feb 7, 2025
src/connections/destinations/catalog/actions-hubspot-cloud/index.md
Outdated
Show resolved
Hide resolved
forstisabella
commented
Feb 7, 2025
forstisabella
commented
Feb 7, 2025
forstisabella
commented
Feb 7, 2025
forstisabella
commented
Feb 7, 2025
forstisabella
commented
Feb 7, 2025
forstisabella
commented
Feb 7, 2025
forstisabella
commented
Feb 7, 2025
forstisabella
commented
Feb 7, 2025
pwseg
reviewed
Feb 13, 2025
src/connections/destinations/catalog/actions-hubspot-cloud/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: pwseg <[email protected]>
pwseg
previously approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions. This is awesome. Great work!
src/connections/destinations/catalog/amazon-personalize/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/optimizely-full-stack/index.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/mobile/android/quickstart.md
Outdated
Show resolved
Hide resolved
Co-authored-by: pwseg <[email protected]>
pwseg
approved these changes
Feb 27, 2025
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As Mark pointed out in 2023, we probably don't need the note callouts in the docs (and the Twilio docs site doesn't have them either 👀). This PR removes all the note callouts and replaces them with the best-fitting other callout (although mostly info). + light Vale edits + removing some outdated information.
Merge timing
Whenever, as I know this is going to be a PITA to review all this (thanks in advance 🫶)
Related issues (optional)