Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note callouts from the docs #7433

Merged
merged 8 commits into from
Feb 27, 2025
Merged

Remove note callouts from the docs #7433

merged 8 commits into from
Feb 27, 2025

Conversation

forstisabella
Copy link
Contributor

Proposed changes

As Mark pointed out in 2023, we probably don't need the note callouts in the docs (and the Twilio docs site doesn't have them either 👀). This PR removes all the note callouts and replaces them with the best-fitting other callout (although mostly info). + light Vale edits + removing some outdated information.

Merge timing

Whenever, as I know this is going to be a PITA to review all this (thanks in advance 🫶)

Related issues (optional)

@forstisabella forstisabella added the back-end fixes or updates to the site itself, which should not go in release notes label Feb 7, 2025
@forstisabella forstisabella requested review from pwseg and a team as code owners February 7, 2025 23:34
@forstisabella forstisabella requested a review from pwseg February 13, 2025 19:19
pwseg
pwseg previously approved these changes Feb 19, 2025
Copy link
Contributor

@pwseg pwseg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions. This is awesome. Great work!

@forstisabella forstisabella merged commit 242947e into develop Feb 27, 2025
4 checks passed
@forstisabella forstisabella deleted the rm-note-callouts branch February 27, 2025 17:30
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end fixes or updates to the site itself, which should not go in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants