Skip to content

Issue #176 - Read the entire http response body after sending a message. #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.0
Choose a base branch
from
Open

Issue #176 - Read the entire http response body after sending a message. #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions analytics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@ func (c *client) report(res *http.Response) (err error) {

if res.StatusCode < 300 {
c.debugf("response %s", res.Status)
// http.Do expectes us to not only close but also fully read the response
// otherwise the Client's underlying RoundTripper may not be able to re-use a persistent TCP
// connection to the server for a subsequent "keep-alive" request.
ioutil.ReadAll(res.Body)
return
}

Expand Down