Skip to content

Leverage the Segment kafka-go writer #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Leverage the Segment kafka-go writer #3

wants to merge 1 commit into from

Conversation

harlow
Copy link

@harlow harlow commented Oct 28, 2017 •
edited
Loading

To simplify the application we can leverage the Segment Kafka Go library.

  • Leverage kafka-go#writer for writing to stream
  • Move config flags to main func

Outstanding questions:

  • Do we need to be concerned w/ the old Cert flags? safe to remove?

@harlow
Leverage the Segment kafka-go writer
d2d5a91 
Simplify the integration by leveraging the Segment Kafka Golang
library.

Minor changes:

* Move config flags to main func
@harlow harlow mentioned this pull request Nov 22, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harlow