🧹 Re-enable Lyrics Widget and clean up dead code #27
Conversation
- Re-enabled the Lyrics Widget using the new transparent window system. - Moved ownership of m_lyrics_widget to ApplicationWidget and switched to a raw pointer in Player for updates. - Added lyrics clearing when stopping playback and during seamless track transitions. - Removed dead members m_toast and m_toast_queue and their commented-out rendering block in updateGUI, as they are superseded by ToastWidget. - Integrated the lyrics widget into the application's window manager with ZOrder::UI. Co-authored-by: segin <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Re-enabled the Lyrics Widget using the new transparent window system. - Moved ownership of m_lyrics_widget to ApplicationWidget and switched to a raw pointer in Player for updates. - Added lyrics clearing when stopping playback and during seamless track transitions. - Removed dead members m_toast and m_toast_queue from Player class. - Upgraded deprecated GitHub Actions (upload-artifact@v4, cache@v4, setup-python@v5, github-script@v7) in .github/workflows/. - Fixed Claude Code action by adding github_token and updating permissions in workflows. Co-authored-by: segin <[email protected]>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
- Removed libvorbisfile-dev from c-cpp.yml as it is provided by libvorbis-dev on Ubuntu 24.04. - Added github_token and updated permissions for Claude actions to support running without the GitHub App. Co-authored-by: segin <[email protected]>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
- Added libcurl4-openssl-dev, libdbus-1-dev, and zlib1g-dev to build workflows. - These dependencies are required for successful compilation on Ubuntu 24.04 Noble. Co-authored-by: segin <[email protected]>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
1 participant
The commented-out rendering logic for the Lyrics Widget in
src/player.cpphas been removed and replaced with a proper implementation integrated into the application's "transparent window system".Changes include:
include/player.h, changedm_lyrics_widgetfrom astd::unique_ptrto a raw pointer and removed unusedm_toastrelated members.src/player.cpp, initializedLyricsWidgetand added it toApplicationWidgetinPlayer::Run.m_lyrics_widget->updatePosition()inPlayer::updateGUI().This improves maintainability by removing dead code and completing a "temporarily disabled" feature using the intended modern architecture.
PR created automatically by Jules for task 4296718918370526988 started by @segin