Implement visible notifications for MPRIS errors #12
Conversation
- Add `SHOW_MPRIS_ERROR` event to `include/psymp3.h`. - Modify `ToastWidget` to support multiline text by splitting on newlines. - Add `show_mpris_errors` configuration option to `PlayerOptions` and `Player` class. - Add `--no-mpris-errors` command-line argument to disable MPRIS error notifications. - Add `Shift+M` keybinding to toggle notifications at runtime. - Update `MPRISManager::reportErrorToPlayer` to dispatch `SHOW_MPRIS_ERROR` event to the main thread. - Implement thread-safe event handling in `Player::handleUserEvent` to show error toasts. - Ensure `<sstream>` is included in `ToastWidget.cpp`. This change allows users to see critical/fatal MPRIS errors on the player UI while providing mechanisms to disable them if desired.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
This change implements visible notifications for MPRIS errors as requested. It modifies
ToastWidgetto handle multiline messages, adds a configuration option to toggle these notifications (both via CLI and runtime keybinding), and connectsMPRISManagerto thePlayer's notification system in a thread-safe manner. Unrelated changes toconfigure.acthat were used for local testing have been reverted.PR created automatically by Jules for task 14111479766382584803 started by @segin