Added hashchange listener #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinKavik
reviewed
Oct 17, 2019
CHANGELOG.md
Outdated
| @@ -2,9 +2,14 @@ | |||
|
|
|||
| ## v0.4.2 | |||
| - Added an `Init` struct, which can help with initial routing (Breaking) | |||
| - Changed `Tag::Custom` to `Tag::from` (Breaking) | |||
There was a problem hiding this comment.
I've updated from function to accept more input types, no other changes, i.e. no breaking changes.
|
Should now work with hash and search, but is still double-firing; I suspect the |
|
@David-OConnor Ping me before merge, please, I would like to do review. |
|
Ready now, assuming it works on @flosse's end. |
@David-OConnor thanks a lot, now it works! |
|
I think we can merge it so we have this fix in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make
Urlparsing from string work with hash and search before merging; currently treats them as part ofpath.