[WebRTC] Add new connection when attempting to re-establish a session that's being torn down#5480
Draft
roxanneskelly wants to merge 1 commit intorelease/2026.02from
Draft
[WebRTC] Add new connection when attempting to re-establish a session that's being torn down#5480roxanneskelly wants to merge 1 commit intorelease/2026.02from
roxanneskelly wants to merge 1 commit intorelease/2026.02from
Conversation
…eing torn down In WebRTC, when tearing down a session with one or more connections, we run into a case where we want to re-establish that session. We need to let the existing connections die, and add new ones to replace them. Estate voice does this automatically, but parcel and adhoc did not. This changes it so that reviving sessions does add the appropriate connections.
akleshchev
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WebRTC, when tearing down a session with one or more connections, we run into a case where we want to re-establish that session. We need to let the existing connections die, and add new ones to replace them.
Estate voice does this automatically, but parcel and adhoc did not. This changes it so that reviving sessions does add the appropriate connections.