Update reset code based on the new OS image. Update ambient light threshold in toggle.#118
Open
arrdalan wants to merge 1 commit into
Open
Update reset code based on the new OS image. Update ambient light threshold in toggle.#118arrdalan wants to merge 1 commit into
arrdalan wants to merge 1 commit into
Conversation
jkaczman
reviewed
Jun 16, 2026
…eshold in toggle.
arrdalan
force-pushed
the
update-reset-toggle
branch
from
7fa5ce4 to
5d1a48b
Compare
jkaczman
reviewed
Jun 17, 2026
| } | ||
|
|
||
| const LIGHT_THRESHOLD: u32 = 40; | ||
| const LIGHT_THRESHOLD: u32 = 20; |
Collaborator
There was a problem hiding this comment.
I think we should document how this threshold is derived, perhaps in a comment here.
On a side note for future work: what if this is a good number for our houses, but it doesn't work well for other users? How can we make this adapt to different conditions?
jkaczman
reviewed
Jun 17, 2026
| .arg("--output=short-iso") | ||
| .arg("-u") | ||
| .arg("secluso.service") | ||
| .arg("secluso_camera_hub.service") |
Collaborator
There was a problem hiding this comment.
We have DEBUG_LOGS_FILENAME as a constant, what about secluso_camera_hub.service? It's used 3x across this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated and tested reset and toggle with the new OS.