Internationalization kick off #2180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisMerinoP
force-pushed
the
internationalization-kick-off
branch
from
4b8280c to
9c0b107
Compare
|
Any comments from the maintiners? Wonder if is there any interest on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First major step toward full ECMA-402 internationalization support in Jint by wiring the engine to the ICU (International Components for Unicode) library provided by the host operating system.
What’s included
Implemented Intl.getCanonicalLocales() and CanonicalizeLocaleList() following the ECMA-402 spec.
Added ICU bindings (uloc_forLanguageTag, uloc_canonicalize, uloc_toLanguageTag) to validate, parse, and canonicalize BCP-47 language tags using the system ICU library.
Implemented normalization logic that mirrors WebKit’s behavior (Webkit code is far more readable than v8).
While this PR focuses mainly on Intl.getCanonicalLocales and locale canonicalization, it establishes the foundation for full internationalization support — unlocking future implementation of Intl.Collator, Intl.NumberFormat, Intl.DateTimeFormat etc. With the tests already in place, to incrementally implement by fixing is relavely doable.
Number of tests fixed:
Across platform testing:
This was done on windows. Maybe needs testing in other OSs.