support selecting individual values #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +101,7 @@ angular.module("ui.multiselect", ["multiselect.tpl.html"]) | |||
| //when directive initialize, newVal usually undefined. Also, if model value already set in the controller | |||
| //for preselected list then we need to mark checked in our scope item. But we don't want to do this every time | |||
| //model changes. We need to do this only if it is done outside directive scope, from controller, for example. | |||
| if(angular.isDefined(newVal)) { | |||
| if(newVal !== oldVal) { | |||
There was a problem hiding this comment.
when the model is set to undefined, you should still update the selection. this still handles the initialization case when both newVal and oldVal are undefined.
|
when selecting an individual attribute instead of the entire object, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.