Make GitHub Action work again #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaseb98
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a bit annoying that the Action is failing all the time because
@preview/clean-math-thesis:0.2.0is (of course) not found. I suggest to import the local lib.typ instead and change back to@preview/clean-math-thesis:0.2.0only once we want to submit the new version. I found that with the current setup it's not possible to use thelvignoli/typst-actionfor that because the relative path../lib.typis not picked up correctly (we would need--root, but this is not supported by the Action). Thus, I propose to switch totypst-community/setup-typst, which should work.