Improve heath checks for Spring and NGINX containers #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, querying the aforementioned path only returns the overall status. Details can be found in the group: `/actuator/health/details`.
However, the "details" group still requires authorization
It only polls the meta endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes two key changes:
The back-end server health check now depends on the status as reported by the actuator. This implies that the server health is now determined by not just the HTTP reachability, but also connection to the database, to the GitHub API and disk space. At the same time, precautions have been taken only to expose the
statuspublically, while keeping all the details behind an endpoint that enforces authorized-only access.The front-end server now has a very basic NGINX status probe as a
stub_status. We introduce a new location for said probe, making it only accessible to thelocalhost. This precaution was taken to prevent the leakage of any sensitive information.