update @actions/core to 1.10.0 #17
Conversation
GitHub is working towards deprecating `set-output` in favour of a file based approach. Update the `@actions/core` dependency to make avail of the new implementation which should hopefully eliminate the deprecation warning.
|
@seanmiddleditch I've recreated the PR (was originally #16) to rename the branch; I'm unsure if this project is now considered abandoned, but I've renamed the branch to allow others to use that as an alternate source to deal with the deprecation until we can sort out how to get this merged. |
Update to node.js 16 as per the deprecation warning from GitHub: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Refresh the build to allow direct use and avoid the warnings from the deprecation of `set-action`.
@actions/core is a core dependency, not a developer dependency. Reflect this in the manifest.
Refresh the built image with the latest changes.
Adjust the invocation of `vswhere` to avoid the version information for the tool.
This introduces a `verbose` option that allows us to easily locate the information about the installation in use without having to infer that.
The package was originally licensed under the MIT license, and the fork did not change that. Adjust the package metadata to reflect this.
Include a note about the new `verbose` option. Update the example to reference the fork, and pin the checkouts action.
When logging in verbose mode the information about the VS instance, we need to join the lines as the output is split on each line. This should clean up the output.
| - uses: actions/checkout@master | ||
| - uses: seanmiddleditch/gha-setup-vsdevenv@master | ||
| - uses: actions/checkout@v4 | ||
| - uses: compnerd/gha-setup-vsdevenv@main |
There was a problem hiding this comment.
Can you revert this change for the PR so it still points to this repo?
|
|
||
| if (verbose) { | ||
| const args = [ | ||
| '-nologo', |
There was a problem hiding this comment.
The first three args are the same as in vswhereArgs; perhaps a separate prefix list of common options should be defined?
| '-latest', | ||
| '-products', '*', | ||
| ].concat(requiresArg) | ||
| const details = spawn(vswherePath, args, { encoding: 'utf8' }) |
There was a problem hiding this comment.
Perhaps just set the stdio args option to [ 'ignore', 'inherit', 'inherit' ] and then not bother with details ? That'll be more efficient (no buffering of input just to dump it back out to standard output), though that probably doesn't matter in any real way here.
| @@ -51,7 +64,7 @@ try { | |||
| if (hostArch != '') | |||
| vsDevCmdArgs.push(`-host_arch=${hostArch}`) | |||
| if (toolsetVersion != '') | |||
| vsDevCmdArgs.push(`-vcvars_vers=${toolsetVersion}`) | |||
| vsDevCmdArgs.push(`-vcvars_ver=${toolsetVersion}`) | |||
There was a problem hiding this comment.
Just to verify, is this a valid bugfix, or a new typo?
| @@ -4,14 +4,16 @@ | |||
| "description": "Setup VS dev environment for GitHub Actions", | |||
| "main": "dist/index.js", | |||
| "author": "Sean Middleditch", | |||
| "license": "CC0", | |||
| "license": "MIT", | |||
There was a problem hiding this comment.
Please revert this; I do not want to require attribution for folks who fork/reuse code this trivial.
|
There's a few different changes here. I'd somewhat prefer them split out into separate PR, e.g. the (Repo isn't fully abandoned; I'm just not a very active maintainer, owning to not being paid to do this and trying to spend more time on non-computer-related hobbies.) |
|
Ah, Thanks @seanmiddleditch! Sorry, I assumed that it was abandoned and starting making more changes. I can certainly split out most of them and send them back here if you are still interested. |
GitHub is working towards deprecating
set-outputin favour of a file based approach. Update the@actions/coredependency to make avail of the new implementation which should hopefully eliminate the deprecation warning.