Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle non-json error responses #263

Merged
merged 7 commits into from
Feb 13, 2025
Merged

fix: Handle non-json error responses #263

merged 7 commits into from
Feb 13, 2025

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Feb 12, 2025 •
edited
Loading

@andrii-balitskyi andrii-balitskyi requested a review from a team as a code owner February 12, 2025 15:37
@razor-x
Copy link
Member

razor-x commented Feb 12, 2025

@andrii-balitskyi we should be able to write a test for this at least for one case
https://github.com/seamapi/javascript-http/blob/12a2198c70bd3e2477de5591fdb2014ee3f486eb/test/seam/connect/http-error.test.ts#L12

razor-x
razor-x reviewed Feb 12, 2025
View reviewed changes
@andrii-balitskyi
Copy link
Contributor Author

@razor-x here's the test 0204dce

@andrii-balitskyi andrii-balitskyi self-assigned this Feb 12, 2025
@razor-x razor-x changed the title Handle non-json error responses fix: Handle non-json error responses Feb 12, 2025
@andrii-balitskyi andrii-balitskyi merged commit 71cb656 into main Feb 13, 2025
24 checks passed
@andrii-balitskyi andrii-balitskyi deleted the andrii/cx-121-handle-non-json-error-response branch February 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razor-x razor-x razor-x approved these changes

Assignees

@andrii-balitskyi andrii-balitskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrii-balitskyi @razor-x