Skip to content

Consolidate names of CAG/data patterns to constraints #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

Consolidate names of CAG/data patterns to constraints #2509

wants to merge 23 commits into from

Conversation

R-Palazzo
Copy link
Contributor

Resolve #2492
CU-86b4ut5ed

I tried to follow the issue carefully and rename everything appropriately, but feel free to double-check terms like 'pattern', 'cag pattern', etc...
Should valide_cag() be renamed validate_constraint() also?

frances-h and others added 23 commits May 4, 2025 16:34
@frances-h @R-Palazzo
Add FixedCombinations CAG pattern + add CAG base class to public (#2400)
b4aa984
@gsheni @R-Palazzo
Add FixedIncrements CAG (#2409)
4405263
@fealho @gsheni @R-Palazzo
Add Inequality CAG (#2405)
0cab593 
Co-authored-by: Gaurav Sheni <[email protected]>
@fealho @gsheni @R-Palazzo
Add Range CAG (#2407)
cc2b26b 
Co-authored-by: Gaurav Sheni <[email protected]>
@fealho @R-Palazzo
Add OneHotEncoding CAG (#2414)
c56dc9c
@fealho @R-Palazzo
Store metadata as Metadata for BaseSynthesizer (#2422)
8b0c6e1
@fealho @R-Palazzo
Add CAG support to single table synthesizers (#2419)
03ba05a
@fealho @R-Palazzo
Make single table CAGs backwards compatible (#2439)
f12b3e1
@lajohn4747 @frances-h
@gsheni @fealho @R-Palazzo
Add deprecation warning to ScalarInequality and ScalarRange (#2442)
fe5fbf8 
Co-authored-by: Frances Hartwell <[email protected]>
Co-authored-by: Gaurav Sheni <[email protected]>
Co-authored-by: Felipe Alex Hofmann <[email protected]>
@R-Palazzo
fix _validate_regex_format after rebasing
dcc50d8
@R-Palazzo
Draft PR to move cag base multi-table logic to SDV public (#2481)
258e10a
@pvk-developer
Add version parameter to SingleTableSynthesizer (#2503)
64e8258
@gsheni @frances-h
@fealho @lajohn4747 @R-Palazzo
Add method to validate CAG pattern for synthetic data (#2485)
db6409b 
Co-authored-by: Frances Hartwell <[email protected]>
Co-authored-by: Felipe Alex Hofmann <[email protected]>
Co-authored-by: John La <[email protected]>
Co-authored-by: R-Palazzo <[email protected]>
Co-authored-by: R-Palazzo <[email protected]>
@R-Palazzo
Inequality CAG errors out if data contains NaN values (#2507)
e454c68
@R-Palazzo
add_cag -> add_constraint + get rid of 'pattern'
2073a6b
@R-Palazzo
skip tests
621ba48
@R-Palazzo
PatternNotMetError -> ConstraintNotMetError
a799bf4
@R-Palazzo
wording pattern -> constraint
9c9ab20
@R-Palazzo
unit tests + BasePattern -> BaseConstraint
6612cbe
@R-Palazzo
add test backward compatibility save/load
391d724
@R-Palazzo
get_cag -> get_constraints
89990b9
@R-Palazzo
rebase
7666cce
@R-Palazzo
cleaning
71274fe
@R-Palazzo R-Palazzo requested review from amontanez24 and frances-h May 8, 2025 13:46
@R-Palazzo R-Palazzo self-assigned this May 8, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner May 8, 2025 13:46
@sdv-team
Copy link
Contributor

sdv-team commented May 8, 2025

Task linked: CU-86b4ut5ed SDV - Consolidate names of CAG/data patterns to constraints #2492

@codecov Codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.19277% with 15 lines in your changes missing coverage. Please review.

Project coverage is 98.22%. Comparing base (e8921f9) to head (71274fe).
Report is 39 commits behind head on feature/single-table-CAG.

Files with missing lines Patch % Lines
sdv/single_table/base.py 92.30% 9 Missing ⚠️
sdv/cag/base.py 92.85% 6 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feature/single-table-CAG    #2509      +/-   ##
============================================================
- Coverage                     98.60%   98.22%   -0.38%     
============================================================
  Files                            59       68       +9     
  Lines                          6234     6994     +760     
============================================================
+ Hits                           6147     6870     +723     
- Misses                           87      124      +37
Flag Coverage Δ
integration 78.53% <90.48%> (-3.98%) ⬇️
unit 97.02% <95.30%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo R-Palazzo removed the request for review from a team May 9, 2025 09:35
@frances-h frances-h force-pushed the feature/single-table-CAG branch from 9eba42f to 7347cc6 Compare May 12, 2025 15:16
@R-Palazzo R-Palazzo force-pushed the feature/single-table-CAG branch from 25e0bea to f3e05bd Compare May 19, 2025 15:08
@R-Palazzo
Copy link
Contributor Author

Will be solved in #2538

@R-Palazzo R-Palazzo closed this May 22, 2025
@R-Palazzo R-Palazzo deleted the issue-2492-cag-to-constraint branch May 29, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@R-Palazzo R-Palazzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@R-Palazzo @sdv-team @frances-h @gsheni @fealho @lajohn4747 @pvk-developer