Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce empty plot if all values are null for get_column_plot #758

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Apr 1, 2025

resolves #757
CU-86b4e3whq

Handle when there is nan values only for both distplot and bar types.

Updated Font size
Plot

@lajohn4747 lajohn4747 requested a review from a team as a code owner April 1, 2025 16:13
@sdv-team
Copy link
Contributor

sdv-team commented Apr 1, 2025

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (2bd9681) to head (eb64d54).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   95.47%   95.53%   +0.05%     
==========================================
  Files         112      112              
  Lines        4357     4363       +6     
==========================================
+ Hits         4160     4168       +8     
+ Misses        197      195       -2     
Flag Coverage Δ
integration 79.78% <0.00%> (-0.11%) ⬇️
unit 83.45% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lajohn4747 lajohn4747 requested a review from pvk-developer April 2, 2025 14:35
@npatki
Copy link
Contributor

npatki commented Apr 2, 2025

@lajohn4747 just eyeballing this one -- the font sizes for all the titles, axes, etc. seem a little off (too small). Are they the same sizes that we usually render for plots?

Also, could we increase the font size of the "No data to visualize" sentence too?

@lajohn4747
Copy link
Contributor Author

lajohn4747 commented Apr 3, 2025

@lajohn4747 just eyeballing this one -- the font sizes for all the titles, axes, etc. seem a little off (too small). Are they the same sizes that we usually render for plots?

Also, could we increase the font size of the "No data to visualize" sentence too?

Yep updated font size.

I don't think anything changed, maybe the github rendering might appear weird. Here is a graph from the main branch and the font sizes are the same when I save them.

Original

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualization get_column_plot crashes if I have a column of all null values
4 participants