-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce empty plot if all values are null for get_column_plot
#758
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 95.47% 95.53% +0.05%
==========================================
Files 112 112
Lines 4357 4363 +6
==========================================
+ Hits 4160 4168 +8
+ Misses 197 195 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@lajohn4747 just eyeballing this one -- the font sizes for all the titles, axes, etc. seem a little off (too small). Are they the same sizes that we usually render for plots? Also, could we increase the font size of the "No data to visualize" sentence too? |
Yep updated font size. I don't think anything changed, maybe the github rendering might appear weird. Here is a graph from the main branch and the font sizes are the same when I save them. |
resolves #757
CU-86b4e3whq
Handle when there is nan values only for both
distplot
andbar
types.Updated Font size
