Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCRBaselineProtection and DCROverfittingProtection metrics #735

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Feb 27, 2025

This is the feature branch for #719 and #720.

resolves #719
resolves #720
resolves #739
CU-86b3w869f
CU-86b3w7pbq

This branch consists of only approved PRs:
#726
#728
#733
#745
#752
#746
#751
#754
#756

@sdv-team
Copy link
Contributor

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (2bd9681) to head (80158dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   95.47%   95.65%   +0.17%     
==========================================
  Files         112      115       +3     
  Lines        4357     4556     +199     
==========================================
+ Hits         4160     4358     +198     
- Misses        197      198       +1     
Flag Coverage Δ
integration 80.61% <96.48%> (+0.72%) ⬆️
unit 84.10% <100.00%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lajohn4747
Copy link
Contributor Author

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (7f08c1e) to head (5981756).

❗ There is a different number of reports uploaded between BASE (7f08c1e) and HEAD (5981756). Click for more details.
HEAD has 1 upload less than BASE

Flag
BASE (7f08c1e)
HEAD (5981756)

integration
1
0

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #735       +/-   ##
===========================================
- Coverage   95.29%   83.69%   -11.60%     
===========================================
  Files         112      115        +3     
  Lines        4378     4570      +192     
===========================================
- Hits         4172     3825      -347     
- Misses        206      745      +539     

Flag Coverage Δ
integration ?
unit 83.69% <100.00%> (+0.71%) ⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

Strange as each of these PRs, code coverage was improved as it tested everything but the combination seems to throw it off.

@lajohn4747 lajohn4747 marked this pull request as ready for review March 31, 2025 16:03
@lajohn4747 lajohn4747 requested a review from a team as a code owner March 31, 2025 16:03
@lajohn4747 lajohn4747 requested a review from amontanez24 April 1, 2025 14:18
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lajohn4747!
Since this is a feature branch, could you try rebasing it from main using
git rebase -i main?
This way, the branch will be up to date with main, and we will mostly maintain one commit per issue solved, which is our goal for any feature branch.
Also because we use rebase and merge for the feature branch rather than the usual squash and merge for other PRs.

@lajohn4747 lajohn4747 force-pushed the dcr_feature_branch branch from 35ef9ce to 80158dd Compare April 2, 2025 15:11
@lajohn4747 lajohn4747 requested a review from R-Palazzo April 2, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants