-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DCRBaselineProtection and DCROverfittingProtection metrics #735
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
==========================================
+ Coverage 95.47% 95.65% +0.17%
==========================================
Files 112 115 +3
Lines 4357 4556 +199
==========================================
+ Hits 4160 4358 +198
- Misses 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Strange as each of these PRs, code coverage was improved as it tested everything but the combination seems to throw it off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lajohn4747!
Since this is a feature branch, could you try rebasing it from main using
git rebase -i main
?
This way, the branch will be up to date with main
, and we will mostly maintain one commit per issue solved, which is our goal for any feature branch.
Also because we use rebase and merge
for the feature branch rather than the usual squash and merge
for other PRs.
Co-authored-by: R-Palazzo <[email protected]>
35ef9ce
to
80158dd
Compare
This is the feature branch for #719 and #720.
resolves #719
resolves #720
resolves #739
CU-86b3w869f
CU-86b3w7pbq
This branch consists of only approved PRs:
#726
#728
#733
#745
#752
#746
#751
#754
#756