Release to Github with Jreleaser #12
Conversation
| id: vars | ||
| shell: bash | ||
| run: | | ||
| version=$(sed -n 's/^version = "\(.*\)"/\1/p' Cargo.toml | head -n1) |
There was a problem hiding this comment.
Wouldn't be something like workflow_dispatch cleaner than extracting the version from the Cargo.toml file?
Something like
workflow_dispatch:
inputs:
version:
description: Release version
required: true
There was a problem hiding this comment.
It depends. If you pass the version as a workflow input don't you still have to update Cargo.toml and Cargo.lock before compilation?
There was a problem hiding this comment.
Yes, I did this on purpose because in Rust projects the Cargo.toml masters of the version. The sed does feel a bit hacky though 🤔
There was a problem hiding this comment.
If Cargo.toml is the source of truth wrt versioning then the GH action must read the version from there. We could use a different mechanism to extract the version tho.
There was a problem hiding this comment.
Yuck! And there is no way to pass in the version. Even good ol' Maven allows this.
jreleaser.toml
Outdated
| windows-x86_64 = "x86_64-pc-windows-msvc" | ||
|
|
||
| [release.github] | ||
| name = "sdkman-native-cli" |
There was a problem hiding this comment.
This could be omitted as the name is grabbed from the .git metadata. If it's set explicitly then it must be changed to match the name of the repository, "sdkman-cli-native"
There was a problem hiding this comment.
Just that one line, or the entire [release.github] block?
I've used the TOML descriptor as this is more idiomatic in a Rust project.