Change Our Availabilities System to Use FullCalendar and Work on Dates instead of Days of The Week #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Holy crap 159 files for review 😱
Is there any way for you to gitignore these files or something so it makes it easy for reviewing? @AhmedNSidd
| profile__id=user_id, day=day)) | ||
| availabilities_in_day = [x for x in Availability.objects.filter( | ||
| profile__id=user_id) if x.start_time.strftime("%A") == day] | ||
| # for availability in availabilities_in_day: |
There was a problem hiding this comment.
if not necessary, remove comments here
|
can this be merged? |
|
@sdevalapurkar Nope. But development on this branch has stopped for the time being. But also can't merge broken code. So gonna close the current PR until development potentially continues in which case the branch can be used to create another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #168. Only initial integration of FullCalendar has been done right now. I expect this to be a big PR which is why I thought might as well put this up for review now instead of sending a huge PR all at once. Also gives me an opportunity to hear from you guys if you have input on the design.. Here's how it looks like right now:
Next steps: Make the add availabilty button work to pull up a modal so people can add availabilites to dates
EDIT: for reviewers: ignore the files in this path: schedule_lessons/static/fullcalendar/ it is just the files for fullcalendar.