Skip to content

Integrate driver matrix fixes #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dkropachev
Copy link
Collaborator

This PR integrates following fixes from driver-matrix:

  1. blockhound exception for CuncurrentMap
  2. Every cluster get's it's own ip prefix
  3. Close session in PeersV2NodeRefreshIT

And add extra fixes:

  1. Remove unnecessary withIpPrefix calls

@dkropachev dkropachev force-pushed the dk/integrate-driver-matrix-fixes branch from 97ebb0a to 867026b Compare June 27, 2025 05:11
@dkropachev dkropachev requested a review from Bouncheck June 27, 2025 05:12
@dkropachev dkropachev self-assigned this Jun 27, 2025
@dkropachev dkropachev force-pushed the dk/integrate-driver-matrix-fixes branch from 867026b to 462272d Compare June 27, 2025 05:46
@Bouncheck
Copy link
Collaborator

I've received a review request but it seems it's not ready yet.

@dkropachev dkropachev force-pushed the dk/integrate-driver-matrix-fixes branch 2 times, most recently from cb4b310 to 91266c7 Compare June 27, 2025 12:26
@dkropachev
Copy link
Collaborator Author

I've received a review request but it seems it's not ready yet.

Please take a look again, all cicd failures have nothing to do with this PR.

Parallel tests falsly failing due to the simulateneuse access to
ConcurrentMap.put
To avoid that let's add it to exception.
Sometimes test can fail to cleanup ccm cluster which will lead to
failure of next tests if their IP addresses clashes.
To avoid that let's spin every cluster on it's own prefix.
@dkropachev dkropachev force-pushed the dk/integrate-driver-matrix-fixes branch from 91266c7 to 0dad79a Compare June 27, 2025 12:59
Copy link
Collaborator

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except PeersV2NodeRefreshIT commit. It introduces a new session variable which looks to be unused to me.

Since cluster is running on it's own ip prefix we can safely run them
without specifing particular ip prefix.
@dkropachev dkropachev force-pushed the dk/integrate-driver-matrix-fixes branch from 0dad79a to 51d7633 Compare June 27, 2025 13:58
@dkropachev dkropachev merged commit 1654ec5 into scylladb:scylla-4.x Jun 27, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants