Skip to content

Conversation

@LLehner
Copy link
Member

@LLehner LLehner commented Nov 20, 2025

Distances to anchor point are now actually normalized for each slide respectively.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.52%. Comparing base (5cd2640) to head (f7b8b2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   65.55%   65.52%   -0.03%     
==========================================
  Files          43       43              
  Lines        6361     6356       -5     
  Branches     1063     1063              
==========================================
- Hits         4170     4165       -5     
  Misses       1808     1808              
  Partials      383      383              
Files with missing lines Coverage Δ
src/squidpy/tl/_var_by_distance.py 65.89% <100.00%> (-1.28%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

df["obs"] = adata.obs_names

# store dataframes by (slide, anchor) combination and also the corresponding maximum distance for normalization
# store dataframes by (slide, anchor) combinationq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@timtreis
Copy link
Member

timtreis commented Nov 22, 2025

Can you describe the issue you're solving here better and then also translate this into a test?

@LLehner
Copy link
Member Author

LLehner commented Nov 23, 2025

Can you describe the issue you're solving here better and then also translate this into a test?

Previous normalization was useless as it just changed the the distance values to be within [0,1] without actually changing the scale. Now the distances from categories with a lower maximum are stretched to be comparable. This doesn't affect the raw distances which are still provided when running this function. I will add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants