Fix: sepal numba compilation options changes the results significantly #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
requested changes
Oct 2, 2025
| def _entropy( | ||
| xx: NDArrayA, | ||
| ) -> float: | ||
| """Get entropy of an array.""" |
There was a problem hiding this comment.
This is what that does right?
Suggested change
| """Get entropy of an array.""" | |
| """Compute Shannon entropy of an array of probability values (in nats).""" |
Nats instead of Shannons, because you use the natural logarithm instead of log2.
Maybe also quote why the result is 0 if the sum is 0? https://stats.stackexchange.com/a/433096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1035