-
Notifications
You must be signed in to change notification settings - Fork 17
Add warning if table_name
and color
are specified but the table doesn't annotate the element
#481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 83.95% 84.08% +0.12%
==========================================
Files 8 8
Lines 1839 1841 +2
==========================================
+ Hits 1544 1548 +4
+ Misses 295 293 -2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors random number generation across the test suite by centralizing it through a standardized function and removes unused RNG variables. It also adds a warning when a specified table doesn't annotate the target element and includes various development environment improvements.
- Replaced direct RNG instantiation with centralized
get_standard_RNG()
function for consistent test reproducibility - Added warning validation when
table_name
andcolor
are specified but the table doesn't annotate the element - Updated development tooling with pixi configuration and GitHub Actions improvements
Reviewed Changes
Copilot reviewed 12 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/conftest.py | Replaced global RNG with get_standard_RNG() function to ensure consistent random state initialization |
tests/pl/test_*.py | Updated all test files to use centralized RNG function and removed unused RNG variables |
src/spatialdata_plot/pl/utils.py | Added warning when specified table doesn't annotate element and simplified assignment syntax |
pyproject.toml | Updated development dependencies and added pixi workspace configuration |
.github/workflows/test.yaml | Migrated to pixi-based testing environment with improved caching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.