-
Notifications
You must be signed in to change notification settings - Fork 18
nan handling for continuous and categorical coloring #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
nan handling for continuous and categorical coloring #427
Conversation
…ints/shapes separately before colored
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 83.75% 83.02% -0.73%
==========================================
Files 8 8
Lines 2555 2681 +126
==========================================
+ Hits 2140 2226 +86
- Misses 415 455 +40
🚀 New features to boost your workflow:
|
| if np.any(color_source_vector.isna()): | ||
| cell_id[color_source_vector.isna()] = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In seg, the value 0 depicts the background, so this would lead to the bg being mapped to the NaN color
The actual label(s) with na in the color_source_vector don't have their id in cell_id anymore, so they're mapped to nothing! => would look like background
|
Hi @timtreis, just wondering what the status of this is, is there a reason why this hasn't been merged yet? I constantly run into this issue, so this would be a very useful thing to have in the package. |
|
Hey @MeyerBender, sorry, will resolve the merge conflicts and get it released today :) |
|
@MeyerBender, there's an edge case that I haven't figured out how to solve yet. Will be a bit delayed |
|
@MeyerBender can you try this branch? |
|
@timtreis Thanks a lot for your efforts! Just tried it on one of my datasets containing NAs and it worked flawlessly. |
|
Great! I discovered two other minor but related issue/inconsistencies which are also fixed in this. I'll have to clean it up a bit but should be out next week. Feel free to give code review if you feel comfortable doing so. |
|
Sounds great, happy to have a look |
Fix coloring of shapes, labels and points when there are nan values in the vectors to color by