Open
Conversation
Given that the code is private and we know which function is used for which widget I removed the overhead that the wrapper creates
Member
|
I'll start by merging the components of this PR that are unrelated to the new ability of adding images in single layer. Regarding that ability, while it is important to give this feature to users, I do not like the idea of having a new widget. This will complicate development and may not be a good choice for UX. I'll explore if I find a minimal way to integrate the new functionality the existing var widget, but if not, I'll close the PR and postpone this work after redesign. In the new work the internal code regarding async loading will still be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users currently don't have the option to select to load individual channels. While the table widget is nice for when working with rasterizations that don't result in large images, for spatial proteomics data in which each channel is large, this is not a nice experience.
This PR presents a first way of improving this.
The channel element widget has the following characteristics:
It updates upon selection chance in the element widget
It has no issues with multiple spatialdata objects as it is based on current selected element
When adding a layer this way, there is a suffix _ch:channel_name.
In addition to that, this PR has removed the colorbar slider in order to make more space for the new widget.
Lastly, this PR fixes a bug of coordinate systems in the CoordinateSystemWidget not being de-duplicated in case of loading multiple SpatialData objects.