-
Notifications
You must be signed in to change notification settings - Fork 163
Load AnnLoader lazily to avoid torch imports when not requested #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Zethson
commented
Apr 10, 2025
•
edited
Loading
edited
- Closes Import torch lazily #1950
- Tests added: No because we don't have have a matrix with torch. Happy to add something if desired.
- Release note added (or unnecessary)
Signed-off-by: Lukas Heumos <[email protected]>
Signed-off-by: Lukas Heumos <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
==========================================
- Coverage 87.13% 85.03% -2.10%
==========================================
Files 47 47
Lines 6848 6850 +2
==========================================
- Hits 5967 5825 -142
- Misses 881 1025 +144
🚀 New features to boost your workflow:
|
Signed-off-by: zethson <[email protected]>
…/anndata into feature/optional_anndata
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@@ -24,3 +24,4 @@ | |||
- Adopt the Scientific Python [deprecation schedule](https://scientific-python.org/specs/spec-0000/) {user}`ilan-gold` ({pr}`1768`) | |||
- Allow {mod}`zarr` v3 writing of data {user}`ilan-gold` ({pr}`1892`) | |||
- {func}`anndata.register_anndata_namespace` functionality for adding custom functionality to an {class}`~anndata.AnnData` object {user}`srivarra` ({pr}`1870`) | |||
- Load AnnLoader lazily to prevent expensive unnecessary `torch` imports when its available on the system. {user}`Zethson` & {user}`flying-sheep` ({pr}`1959`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this (without the -
) belongs into a file called 1959.performance.md
that you create using hatch towncrier:create
0.12.0rc1 is already released and its release notes are complete.