No std rstd #28
Merged
No std rstd #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
September 18, 2019 12:59
Contributor
Author
|
I suggest to merge although example_contract is broken. If someone wants to use it, I've added a hint |
Contributor
Author
|
the recent merge commit broke no_std, need to fix this first |
Contributor
Author
|
no_std fix works |
clangenb
reviewed
Sep 28, 2019
| pub mod xt_primitives; | ||
|
|
||
| pub extern crate codec; | ||
| pub extern crate log; |
Collaborator
There was a problem hiding this comment.
Has this been done for a reason?
I made this for issue #16 . This re-exports the dependencies locally. Making them available in the macro via crate::....
Then third parties using substrate-api-client do not need to import the codec and log dependencies
Contributor
Author
There was a problem hiding this comment.
the reason for removing it is that it breaks no_std
Collaborator
There was a problem hiding this comment.
try reexporting conditionally, only if in std environment
Collaborator
|
apart from my comment i think this is ready to merge. |
clangenb
force-pushed
the
no_std_rstd
branch
from
8fc8952 to
9b53214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
no_stdsupport. (without depending onsgx_tstd)In order for this to work, I had to fork
substrate-primitivesand enable crypto primitives.This also drops dependency on custom runtime crate.
TODO:
example_contractis broken. blocker: drop dependency of examples on test node_runtime crate #26