Skip to content

feat: support directly forward transactions to sequencer #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Jul 3, 2025

Counterpart of l2geth scroll-tech/go-ethereum#1208.
Related Reth PR: scroll-tech/reth#265

Added a new flags on NetworkArgs.
network.sequencer-url: This will be passed to ScrollEthApiBuilder, If not None, Reth will forward transactions to sequencer's RPC directly.

@yiweichi yiweichi requested review from frisitano and greged93 July 6, 2025 20:02
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment inline.

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an e2e test for this using the test framework. See example provided:

#[tokio::test]
async fn can_sequence_and_gossip_blocks() {

@yiweichi
Copy link
Member Author

yiweichi commented Jul 9, 2025

Can we add an e2e test for this using the test framework. See example provided:

#[tokio::test]
async fn can_sequence_and_gossip_blocks() {

Sure, let me do that.

@frisitano
Copy link
Collaborator

Sure, let me do that.

Thanks, I think you'll need to set no_local_transactions_propagation to true in the node config when launching the test nodes:

https://github.com/scroll-tech/reth/blob/766dd271b0bd71315cef665d1eeb81ab86b891e0/crates/node/core/src/args/txpool.rs#L90-L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants