-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add gaslimit check for execute_sequencer_transactions #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: scroll
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #333 will not alter performanceComparing Summary
|
}, | ||
)); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't work for L1 message, as currently we only add gas_used
to info.cumulative_gas_used
, we need to have the same logic as l2geth:
- For normal transactions, subtract tx gas used from the available gas.
- For L1 messages, subtract tx gas limit from the available gas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed bfd3574
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and btw, do i need to add this check
let gas_used = sequencer_tx.is_l1_message() {
...
} else {
...
}
as we discussed, I think l1 consolidation and l1 message can combine together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to yes, for L1 messages you use gas limit but for normal you use gas used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is also a limit for normal transaction, it also use gasLimit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I think we don't need to distinguish the tx type
#280