[precompile] Add fixed_witness_group() to officially generate fixed witnesses.
#975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
reviewed
Jul 3, 2025
dreamATD
force-pushed
the
precompile-prepare-fixed
branch
from
db2a564 to
683e192
Compare
hero78119
reviewed
Jul 7, 2025
| @@ -558,6 +558,20 @@ where | |||
| { | |||
| type Trace = KeccakTrace; | |||
|
|
|||
| fn fixed_witness_group(&self) -> RowMajorMatrix<E::BaseField> { | |||
There was a problem hiding this comment.
👍
Not this line, but per our offline discussion, to complete functionality, we need expand (i.e. iter().cycle() in rust) fixed poly dynamically via num_instances. I will come back to this part when I make the e2e integration
There was a problem hiding this comment.
Do you mean the returned matrix should be the padded version?
There was a problem hiding this comment.
return matrix should be original size for commit into mpcs.
the place of padding should be gkr_witness, or another define another stage when know num_instance at that moment.
|
I cherry-pick these 2 commit into another PR #980 as I need these fixed input features for integration tests. What do you think we close this PR :) ? |
dreamATD
force-pushed
the
precompile-prepare-fixed
branch
from
683e192 to
cc34720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.