Update to Ceno's version of the toolchain #12
Conversation
|
The |
Also rename to `config.toml` to make the newer cargo happy
matthiasgoergens
force-pushed
the
matthias/update-toolchain
branch
from
e7eb575 to
dda1bbc
Compare
| @@ -24,17 +24,6 @@ pub enum Token { | |||
| // Identifiers | |||
| #[regex(br"#t|#a|#l|#m|[^()0-9#; \t\n\f][^(); \t\n\f#]*")] | |||
There was a problem hiding this comment.
This one clashed with the 'Literals' section above. I suggest perhaps fixing this regex? For now, I just bumped the priority on the Literals.
spartan_parallel/src/lib.rs
Outdated
| let mut init_vir_mems_list = init_vir_mems_list.into_iter().map(|v| v.assignment).collect_vec(); | ||
| let mut addr_phy_mems_list = addr_phy_mems_list.into_iter().map(|v| v.assignment).collect_vec(); | ||
| let mut addr_vir_mems_list = addr_vir_mems_list.into_iter().map(|v| v.assignment).collect_vec(); | ||
| let mut addr_ts_bits_list = addr_ts_bits_list.into_iter().map(|v| v.assignment).collect_vec(); |
There was a problem hiding this comment.
Are there any sayings about using collect::<Vec<_>> instead of collect_vec?
There was a problem hiding this comment.
Oh, they are basically the same. It's just that collect comes from the standard library, and collect_vec comes from itertools.
Let me try to remember why this one changed.
There was a problem hiding this comment.
Oh, I figured it out: collect_vec wasn't available by default anymore. So we would have needed to import it. But this was cleaner.
matthiasgoergens
force-pushed
the
matthias/update-toolchain
branch
from
faeb390 to
b9db585
Compare
spartan_parallel/.cargo/config
Outdated
There was a problem hiding this comment.
This was actually just a rename to spartan_parallel/.cargo/config.toml
ff/Cargo.toml
Outdated
| ff_derive = { version = "0.12.1", path = "ff_derive", optional = true } | ||
| rand_core = { version = "0.6", default-features = false } | ||
| subtle = { version = "2.2.1", default-features = false, features = ["i128"] } | ||
| ff_derive = { version = "0", path = "ff_derive", optional = true } |
There was a problem hiding this comment.
seems not a good idea. v0.x and v0.y don't need to be compatible in sem ver
ff_derive = { version = "0",
There was a problem hiding this comment.
They actually need to be compatible in semantic versioning. But you are right that in practice they often aren't.
Fixed.
We are getting a lot of flak from dependabot about security problems in dependencies.
So let's update our dependencies to fix them.
Also rename to
config.tomlto make the newer cargo happy.