RaspberryPiFoundation feature enhancements #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remixProject reducer is already being exported from the `src/exported-reducers.ts` file which makes this export redundant.
The MenuBar is quite specific to the canonical version of the online Scratch editor [1]. In RaspberryPiFoundation projects we want to make use of the scratch-gui package without displaying the MenuBar. Since the height of the menu bar is hard-coded as a CSS variable, I've had to override the height calculation for the body wrapper when the menu bar is not visible. Ideally the height of the menu bar wouldn't be hard-coded and this wouldn't be necessary. [1]: https://scratch.mit.edu/projects/editor Co-authored-by: James Mead <[email protected]>
This will allow us to trigger the saving of a project from outside the GUI component. Co-authored-by: James Mead <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request includes a number of changes from the RaspberryPiFoundation fork of scratch-gui:
menuBarHiddenprop).manualUpdateProjectreducer.Reason for Changes
We maintain a number of forks of scratch-gui across the RaspberryPiFoundation which we are looking at rationalising. We believe that these particular changes could be useful for other people and therefore would be keen to get these features merged upstream.
Test Coverage
We were unable to find an existing unit test for the Gui component and so we have not added any test coverage around the new
menuBarHiddenprop.