Spork: unfork Blockly #214
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: run stacks in response to stack click events * refactor: listen for regular click events to run block stacks
…extensions toolbox categories (#2)
* fix: handle modern workspace comment events * fix: correctly access coordinates on events
* chore: format runtime.js * fix: add the hat extension to extension hat blocks
… occupied by a shadow block (#8) * chore: format engine/blocks.js * fix: restore shadow blocks when removing a block from an input
…locks getting into a bad state (#9)
The playgrounds themselves are still broken, but it's a step...
…ty with patched scratch-blocks (#1)
* fix: add support for Scratch-style procedures * refactor: remove underscore procedure creation callback
…toolbox categories (#9)
|
Another issue: block comments are attached to the wrong side of the block in RTL.
|
|
When dragging a custom block definition onto a stack the shadow is not resized to the correct width: |
|
Thanks for all the comments and bug reports! At this time, I believe everything reported here has been resolved in my fork; feel free to report any more issues you encounter in my repo, I very much appreciate it. |
cwillisf
force-pushed
the
spork
branch
10 times, most recently
from
6bf544f to
10e6b7c
Compare
cwillisf
force-pushed
the
spork
branch
3 times, most recently
from
594cf8f to
d365a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use the new version of
scratch-blocks, which now depends on Blockly instead of being a fork of Blockly.Reason for Changes
As stated in scratchfoundation/scratch-blocks#3338:
Test Coverage
Many existing tests at least partially cover these changes. We'll also be testing these changes through several manual testing sessions.