Allow an empty crc in a 14 byte header #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As specified in ANT FIT Protocol Rev2.4 Paragraph 3.3.1 "Computing the CRC is optional when using a 14 byte file header, it is permissible to set it to 0x0000."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in ANT FIT Protocol Rev2.4 Paragraph 3.3.1 "Computing the CRC
is optional when using a 14 byte file header, it is permissible to set it to
0x0000."
The FIT files from my forrunner 610 have not crc set. The two crc bytes in the file header are 0x0000. As specified in the protocol this is allowed. However the code this not account for this. Without this fix, reading the FIT file wil log an Error