-
Notifications
You must be signed in to change notification settings - Fork 405
feat(tmux): complete target-session arguments #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
completions/tmux
Outdated
| file | *-file | path | *-path) | ||
| _comp_compgen_filedir | ||
| ;; | ||
| target-session | src-session) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you see src-session in output from tmux? I only found it in the tmux source, but it doesn't seem to be used currently. If we do want to have it here anyway, we should probably also have dst-session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I asked an AI to look at tmux output and propose those options. I see that target-session is the only option that is used in the usage output, so we can trim this down to one option name.
b5bc410 to
91c76c4
Compare
91c76c4 to
b5bc410
Compare
|
The |
b5bc410 to
18b6da4
Compare
|
I've squashed the tree and rebased onto main HEAD |
akinomyoga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This adds completion for session names. Commands which take a running session's name as an argument, for example
attach-session, can now have those options completable. For example:I checked the tmux repo, and they do not maintain bash completions, so I'm submitting this here.